forked from open-telemetry/opentelemetry-python-contrib
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prometheus Remote Write Exporter (6/6) #14
Closed
AzfaarQureshi
wants to merge
19
commits into
6-prometheus-remote-write
from
5-prometheus-remote-write
Closed
Prometheus Remote Write Exporter (6/6) #14
AzfaarQureshi
wants to merge
19
commits into
6-prometheus-remote-write
from
5-prometheus-remote-write
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AzfaarQureshi
commented
Nov 27, 2020
Comment on lines
+42
to
+43
opentelemetry-api >= 0.16b0 | ||
opentelemetry-sdk >= 0.16b0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
after release 0.16b0 we can just install the api from PyPi
AzfaarQureshi
force-pushed
the
5-prometheus-remote-write
branch
2 times, most recently
from
November 28, 2020 23:36
80ec1a0
to
6052036
Compare
AzfaarQureshi
force-pushed
the
5-prometheus-remote-write
branch
4 times, most recently
from
November 29, 2020 03:59
59e37ab
to
36944fb
Compare
AzfaarQureshi
force-pushed
the
5-prometheus-remote-write
branch
3 times, most recently
from
November 30, 2020 18:22
6a18319
to
59b9aa0
Compare
AzfaarQureshi
force-pushed
the
5-prometheus-remote-write
branch
from
November 30, 2020 18:47
59a01fe
to
2f1b647
Compare
AzfaarQureshi
force-pushed
the
5-prometheus-remote-write
branch
from
November 30, 2020 19:20
caf5144
to
caf76ab
Compare
AzfaarQureshi
force-pushed
the
5-prometheus-remote-write
branch
2 times, most recently
from
November 30, 2020 20:24
f13658b
to
d8ecbdc
Compare
AzfaarQureshi
force-pushed
the
5-prometheus-remote-write
branch
from
November 30, 2020 20:28
d8ecbdc
to
8312a08
Compare
AzfaarQureshi
force-pushed
the
5-prometheus-remote-write
branch
from
November 30, 2020 20:33
8312a08
to
c21dd66
Compare
shovnik
approved these changes
Dec 1, 2020
alolita
approved these changes
Dec 1, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
AzfaarQureshi
force-pushed
the
5-prometheus-remote-write
branch
4 times, most recently
from
December 1, 2020 23:55
cdc4bb3
to
d5d83d4
Compare
AzfaarQureshi
force-pushed
the
5-prometheus-remote-write
branch
from
December 2, 2020 00:01
d5d83d4
to
59b04ac
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is PR 2/6 of adding a Prometheus Remote Write Exporter in Python SDK and address Issue open-telemetry/opentelemetry-python#1302
Part 1/6
Part 2/6
Part 3/6
Part 4/6
Part 5/6
👉 Part 6/6
Type of change
How Has This Been Tested?
Readme and documentation changes
Does This PR Require a Core Repo Change?
Checklist:
Documentation has been updatedcc- @shovnik, @alolita